Skip to content

Fix #2994 #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Fix #2994 #3750

merged 1 commit into from
Jan 18, 2018

Conversation

allanrenucci
Copy link
Contributor

This reverts #2823.

Compiling:

object Test {
  object Energy {
    private def parse(value: Any) = ???
    def apply = parse _
  }

  Energy("")
}

now emits:

-- [E050] Reference Error: tests/allan/Test.scala:7:2 --------------------------
7 |  Energy("")
  |  ^^^^^^
  |  object Energy in object Test does not take parameters

But now compiling:

 case class Foo[T](x: T)
 object Foo { def apply[T]() = Foo(???) }

emits:

-- [E050] Reference Error: tests/allan/Test.scala:11:31 ------------------------
11 | object Foo { def apply[T]() = Foo(???) }
   |                               ^^^
   |                               object Foo does not take parameters

instead of

-- [E044] Syntax Error: tests/allan/Test.scala:11:31 ---------------------------
11 | object Foo { def apply[T]() = Foo(???) }
   |                               ^^^
   |                    overloaded or recursive method Foo needs return type

ref #1731

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Added" instead of "Add")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@nicolasstucki
Copy link
Contributor

We should add a test case in a repl scripted to make sure this regression does not happen again.

@allanrenucci
Copy link
Contributor Author

I'd like to discuss this PR in the next Dotty meeting. It fixes #2994 but reopen #1731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants